From ee2ceca8d14f3a69c4cb15a370198fa24071bc65 Mon Sep 17 00:00:00 2001
From: Mohammad Ghasembeigi <webmaster@mohammadg.com>
Date: Sun, 6 Dec 2015 03:08:08 +1100
Subject: [PATCH] Remove unnecessary 'visitDecl' default cases.

The default cases are unnecessary and provide no benefits so they should
just be removed.
---
 tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp | 3 ---
 tools/swift-ide-test/ModuleAPIDiff.cpp             | 4 ----
 2 files changed, 7 deletions(-)

diff --git a/tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp b/tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp
index c5ade1de03308..138721d8bfaf5 100644
--- a/tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp
+++ b/tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp
@@ -156,9 +156,6 @@ class UIdentVisitor : public ASTVisitor<UIdentVisitor,
 public:
   explicit UIdentVisitor(bool IsRef) : IsRef(IsRef) { }
 
-  /// TODO: reconsider whether having a default case is a good idea.
-  UIdent visitDecl(const Decl *D) { return UIdent(); }
-
   UIdent visitFuncDecl(const FuncDecl *D);
   UIdent visitVarDecl(const VarDecl *D);
   UIdent visitExtensionDecl(const ExtensionDecl *D);
diff --git a/tools/swift-ide-test/ModuleAPIDiff.cpp b/tools/swift-ide-test/ModuleAPIDiff.cpp
index bea38fc3ab948..12e9cd708f25a 100644
--- a/tools/swift-ide-test/ModuleAPIDiff.cpp
+++ b/tools/swift-ide-test/ModuleAPIDiff.cpp
@@ -781,10 +781,6 @@ class SMAModelGenerator : public DeclVisitor<SMAModelGenerator> {
     return Result;
   }
 
-  void visitDecl(Decl *D) {
-    // FIXME: maybe don't have a default case
-  }
-
   void visitStructDecl(StructDecl *SD) {
     auto ResultSD = std::make_shared<sma::StructDecl>();
     ResultSD->Name = convertToIdentifier(SD->getName());