[AutoDiff] Add Differentiable.zeroTangentVectorInitializer.
#28310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Differentiable.zeroTangentVectorInitializer` requirement will enable correct, efficient reverse-mode differentiation of struct property accesses. A `zeroTangentVectorInitializer` closure is more efficient than a `zeroTangentVector` computed property, which would always capture `self`. Add `Differentiable.zeroTangentVector` default instance property, which returns `self.zeroTangentVectorInitializer()`. Todos: - Implement derived conformances for `zeroTangentVectorInitializer`. - Implement differentiation transform support for `zeroTangentVectorInitializer` and struct projection instructions.
rxwei
reviewed
Nov 17, 2019
| """) | ||
| var zeroTangentVector: TangentVector { get } | ||
| var zeroTangentVectorInitializer: () -> TangentVector { get } |
There was a problem hiding this comment.
Eventually this property declaration (in the protocol) should have a @noDerivative on it, and potentially require all conforming types to specify a @noDerivative ... when we support differentiable curry.
rxwei
approved these changes
Nov 17, 2019
dan-zheng
commented
Nov 17, 2019
|
|
||
| /// A tangent vector initialized using `zeroTangentVectorInitializer`. | ||
| /// `move(along: zeroTangentVector)` should not modify `self`. | ||
| var zeroTangentVector: TangentVector { zeroTangentVectorInitializer() } |
There was a problem hiding this comment.
Unfortunately, there's a availability warning when compiling the standard library:
Differentiable.swift:97:42: warning: 'zeroTangentVectorInitializer' is deprecated: `zeroTangentVectorInitializer` derivation has not been implemented; do not use this property
var zeroTangentVector: TangentVector { zeroTangentVectorInitializer() }
^
I think this is acceptable for now.
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Differentiable.zeroTangentVectorInitializerrequirement will enablecorrect, efficient reverse-mode differentiation of struct property accesses.
A
zeroTangentVectorInitializerclosure is more efficient than azeroTangentVectorcomputed property, which would always captureself.Add
Differentiable.zeroTangentVectordefault instance property, whichreturns
self.zeroTangentVectorInitializer().Todos:
zeroTangentVectorInitializer.zeroTangentVectorInitializerand struct projection instructions.