Remove SILGen support code for curry thunks #30485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that CSApply transforms partial applications into closures, we never see AST with partially-applied method calls. So all the machinery for emitting curry thunks is now gone.
Now that curry thunks are gone, we can do a bit more refactoring to guarantee that an ApplyExpr always has the *exact* number of call sites expected. Extra call sites are handled by emitting the innermost ApplyExpr as an indirect callee, eliminating a special code path.
There was a bunch of book-keeping here that became dead.
slavapestov
force-pushed
the
silgen-cleanup-sr-75
branch
from
8352845 to
052309e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first cleanup from landing #28698. Also fixes a case where I missed creating a curry thunk in Sema, which was exposed by removing the SILGen code for it.