[AutoDiff upstream] add more validation tests #31190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrasi
force-pushed
the
upstream-test-validation-3
branch
from
9f3dc2c to
7f5d051
Compare
rxwei
approved these changes
Apr 21, 2020
|
@swift-ci please test tensorflow |
|
oops, wrong ci command |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These needed some modifications from the
tensorflowbranch.test/AutoDiff/validation-test/subset_parameters_thunk.swift:
import _Differentiationtensorflowbranch had both things in the same file.test/AutoDiff/validation-test/cross_module_derivative_attr.swift:
-enable-experimental-cross-file-derivative-registration.import_Differentiation.test/AutoDiff/validation-test/custom_derivatives.swift:
import _Differentiation.#if os(macOS)to#if os(macOS) || os(iOS) || os(watchOS) || os(tvOS)..withRecomputationInPullbackstests because that doesn't exist inmaster.