Skip to content

[5.3] Add all the ptrauth IR attributes that Clang does #31963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

rjmccall
Copy link
Contributor

@rjmccall rjmccall commented May 22, 2020

A more modest fix for rdar://63289339 for the 5.3 release. The fix I made on master, #31906, potentially changes a lot of other attributes and so has a substantial amount of extra risk. The risk for this PR is really just the inherent risk of guaranteeing traps during auths.

@rjmccall rjmccall requested a review from a team as a code owner May 22, 2020 04:21
@rjmccall rjmccall requested a review from DougGregor May 22, 2020 04:23
@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - be86f8b8cc40eab838f241e28550c64683636b7a

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - be86f8b8cc40eab838f241e28550c64683636b7a

A more modest fix for rdar://63289339 for the 5.3 release.
@rjmccall rjmccall force-pushed the ir-ptrauth-attributes-5.3 branch from be86f8b to a9e97b3 Compare May 22, 2020 05:20
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - be86f8b8cc40eab838f241e28550c64683636b7a

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - be86f8b8cc40eab838f241e28550c64683636b7a

@rjmccall
Copy link
Contributor Author

rjmccall commented Jun 8, 2020

@swift-ci Please test.

@tkremenek tkremenek merged commit 3e0b2b8 into swiftlang:release/5.3 Jun 10, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants