Skip to content

Make note on PYTHON_EXECUTABLE more prominent in WindowsBuild.md #32007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2020
Merged

Make note on PYTHON_EXECUTABLE more prominent in WindowsBuild.md #32007

merged 2 commits into from
May 30, 2020

Conversation

martinboehme
Copy link
Contributor

Make the note on needing to adjust PYTHON_EXECUTABLE more prominent, and repeat in in the place where that argument actually needs to be adjusted.

@martinboehme
Update WindowsBuild.md
e530ef8 
Make the note on needing to adjust `PYTHON_EXECUTABLE` more prominent, and repeat in in the place where that argument actually needs to be adjusted.
@martinboehme martinboehme requested a review from compnerd May 25, 2020 14:46
@martinboehme
Copy link
Contributor Author

@swift-ci Please test

compnerd
compnerd approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable thing.

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e530ef8

@martinboehme
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e530ef8

@martinboehme
Copy link
Contributor Author

@swift-ci Please smoke test.

@martinboehme
Copy link
Contributor Author

@swift-ci Please smoke test Linux

2 similar comments
@martinboehme
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@martinboehme
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@martinboehme
Copy link
Contributor Author

@swift-ci Please smoke test

@martinboehme martinboehme merged commit 88b804b into master May 30, 2020
@martinboehme martinboehme deleted the martinboehme-patch-1 branch May 30, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinboehme @swift-ci @compnerd