Skip to content

Revert "[metadata prespecialization] Support for classes." #32097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

compnerd
Copy link
Member

Reverts #30089

@compnerd
Copy link
Member Author

@swift-ci please test

@nate-chandler
Copy link
Contributor

Hi @compnerd , wouldn't it be more expedient to simply change the name in a different PR?

@compnerd
Copy link
Member Author

compnerd commented May 30, 2020

@nate-chandler that sounds good to me. Could you please put up a PR to do that? My machine is updating (and will take some time).

This is the output from the logs:

error: unable to create file test/IRGen/prespecialized-metadata/class-fileprivate-inmodule-1argument-2ancestors-1distinct_use-1st_ancestor_generic-1argument-1st_argument_constant_int-2nd_ancestor_generic-1st-argument_constant_double.swift: Filename too long
error: unable to create file test/IRGen/prespecialized-metadata/class-fileprivate-inmodule-1argument-2ancestors-1distinct_use-1st_ancestor_generic-1argument-1st_argument_constant_int-2nd_ancestor_generic-1st-argument_subclass_argument.swift: Filename too long
error: unable to create file test/IRGen/prespecialized-metadata/class-fileprivate-inmodule-1argument-2ancestors-1distinct_use-1st_ancestor_generic-1argument-1st_argument_subclass_argument-2nd_ancestor_generic-1st-argument_constant_int.swift: Filename too long

@nate-chandler nate-chandler self-requested a review May 30, 2020 00:58
@nate-chandler
Copy link
Contributor

@compnerd Yup, doing it now. Thanks for the logs!

@nate-chandler
Copy link
Contributor

Okay, renaming PR is smoke testing at #32098 .

@compnerd
Copy link
Member Author

Thanks for fixing up things!

@compnerd compnerd closed this May 30, 2020
@compnerd compnerd deleted the revert-30089-generic-metadata-prespecialization-components/classes branch May 30, 2020 01:18
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 349110d

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 349110d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants