Skip to content

[metadata prespecialization] Support classes with non-generic ancestors. #32174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

[metadata prespecialization] Support classes with non-generic ancestors. #32174

merged 1 commit into from
Jun 9, 2020

Conversation

nate-chandler
Copy link
Contributor

Previously, metadata prespecialization for classes only occurred when all of a specialized generic class's ancestors were themselves generic. Here, that requirement is lifted so that generic classes with concrete ancestors are also eligible for prespecialization.

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test Linux Platform
Git Sha - 1698f8663c120e9b5e97f6736ca4df468a44d7cc

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 1698f8663c120e9b5e97f6736ca4df468a44d7cc

@nate-chandler nate-chandler force-pushed the generic-metadata-prespecialization-components/classes-nongeneric-superclasses branch from 1698f86 to 52bf272 Compare June 4, 2020 20:26
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test Linux Platform
Git Sha - 1698f8663c120e9b5e97f6736ca4df468a44d7cc

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 1698f8663c120e9b5e97f6736ca4df468a44d7cc

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 52bf27282bfab3a6bec13b0389b559ebf217216f

@nate-chandler nate-chandler force-pushed the generic-metadata-prespecialization-components/classes-nongeneric-superclasses branch 2 times, most recently from c70b256 to b024fb7 Compare June 5, 2020 01:01
@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2020

Build failed
Swift Test OS X Platform
Git Sha - 52bf27282bfab3a6bec13b0389b559ebf217216f

@nate-chandler nate-chandler force-pushed the generic-metadata-prespecialization-components/classes-nongeneric-superclasses branch from b024fb7 to c373a49 Compare June 5, 2020 18:42
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2020

Build failed
Swift Test Linux Platform
Git Sha - 52bf27282bfab3a6bec13b0389b559ebf217216f

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2020

Build failed
Swift Test OS X Platform
Git Sha - b024fb7802670706210ad1bc5793e3e4cb192c85

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

1 similar comment
@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

@nate-chandler nate-chandler force-pushed the generic-metadata-prespecialization-components/classes-nongeneric-superclasses branch from c373a49 to 602faa2 Compare June 5, 2020 23:55
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2020

Build failed
Swift Test Linux Platform
Git Sha - c373a494569be52638ec68f4cf5c367cc2b06f98

@swift-ci
Copy link
Contributor

swift-ci commented Jun 6, 2020

Build failed
Swift Test OS X Platform
Git Sha - c373a494569be52638ec68f4cf5c367cc2b06f98

@nate-chandler nate-chandler marked this pull request as ready for review June 8, 2020 16:35
@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
[metadata prespecialization] Support classes with non-generic ancestors.
8ec75d4 
Previously, metadata prespecialization for classes only occurred when
all of a specialized generic class's ancestors were themselves generic.
Here, that requirement is lifted so that generic classes with concrete
ancestors are also eligible for prespecialization.
@nate-chandler nate-chandler force-pushed the generic-metadata-prespecialization-components/classes-nongeneric-superclasses branch from 602faa2 to 8ec75d4 Compare June 8, 2020 21:58
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

@swift-ci
Copy link
Contributor

swift-ci commented Jun 8, 2020

Build failed
Swift Test Linux Platform
Git Sha - 602faa247f1db651d1f2139171931efe2168edb3

@swift-ci
Copy link
Contributor

swift-ci commented Jun 8, 2020

Build failed
Swift Test OS X Platform
Git Sha - 602faa247f1db651d1f2139171931efe2168edb3

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos

@swift-ci
Copy link
Contributor

swift-ci commented Jun 8, 2020

Build failed
Swift Test OS X Platform
Git Sha - 8ec75d4

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test os x platform

@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2020

Build failed
Swift Test OS X Platform
Git Sha - 8ec75d4

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test os x platform

@nate-chandler nate-chandler merged commit 7c5a5e5 into swiftlang:master Jun 9, 2020
@nate-chandler nate-chandler deleted the generic-metadata-prespecialization-components/classes-nongeneric-superclasses branch June 9, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nate-chandler @swift-ci