[5.3][CodeCompletion] Skip to '=' after completion in 'if'/'guard' pattern #32286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the parser can parse the subject expresion which provides the expected type of the pattern. rdar://problem/56802036 (cherry picked from commit f107a15)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
tkremenek
approved these changes
Jun 10, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32062 into
release/5.3casepattern iniforguardstatement (e.g.if case .<HERE>(let foo) = something { ... }) the type of the pattern is determined by its initializer. Previously, the parser used to give up parsing the initializer, so it couldn't provide useful completions. This patch adds a parser recovery to skip to=after completion token so that it can type check the initializer expression.casepattern forif/guardstatement