Skip to content

[5.3][CodeCompletion] Add keypath apply subscript after open bracket #32287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 10, 2020

Cherry-pick of #31980 into release/5.3

  • Explanation: Most expression has [keyPath: ] subscript since SE-0161. But code completion didn't use to suggest calling signature of it. This patch adds [keyPath: ] subscript calling signature completion after opening bracket.
  • Scope: Calling signature completion after open bracket
  • Risk: Low.
  • Testing: Added regression test cases
  • Issue: rdar://problem/61016147
  • Reviewer: Ben Langmuir (@benlangmuir)

rdar://problem/61016147
(cherry picked from commit 38d8b13)
@rintaro rintaro requested a review from a team as a code owner June 10, 2020 01:47
@rintaro
Copy link
Member Author

rintaro commented Jun 10, 2020

@swift-ci Please test

@rintaro rintaro added the r5.3 label Jun 10, 2020
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5753754

@rintaro
Copy link
Member Author

rintaro commented Jun 10, 2020

@swift-ci Please test Linux

@rintaro
Copy link
Member Author

rintaro commented Jun 10, 2020

@swift-ci Please nominate

@tkremenek tkremenek merged commit 38b2066 into swiftlang:release/5.3 Jun 10, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants