[5.3] [CS] Fix a crash in AllowArgumentMismatch #32361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the index expression isn't a tuple or paren expression
theblixguy
changed the title
|
@swift-ci please test |
|
Thank you! |
DougGregor
approved these changes
Jun 15, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32356 with an adjustment (using
isainstead ofisExpras it doesn't exist on 5.3 branch).Explanation: The compiler was crashing because
AllowArgumentMismatchrelies ongetFunctionArgApplyInfo()returning a non-optionalFunctionArgApplyInfovalue, which we failed to provide in a situation whensimplifyLocatorcouldn't simplify a locator where aTypeExprwas provided as a subscript argument.Scope: Affects use of subscript expressions.
SR Issue: SR-12990.
Risk: Low. This fixes a compiler crash which was found by the stress tester.
Testing: Added a validation test
Reviewed by: @xedin
Resolves: rdar://problem/64303153