Skip to content

[5.3][Function Builders] Fix a function builder crash due to constraint generation failures #32608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Jun 29, 2020

This crash was fixed in a recent refactoring on master (#32221). This change takes one line from that refactoring which records whether or not there was an error when generating constraints for a pattern binding decl in a function builder.

Tests are cherry-picked from #32607

Resolves: rdar://problem/59856491

@hborla hborla requested a review from DougGregor June 29, 2020 22:24
@hborla hborla requested a review from a team as a code owner June 29, 2020 22:24
@hborla
Copy link
Member Author

hborla commented Jun 29, 2020

@swift-ci please test

@hborla hborla added the r5.3 label Jun 30, 2020
@hborla hborla merged commit e4e6684 into swiftlang:release/5.3 Jun 30, 2020
@hborla hborla deleted the 5.3-function-builder-csgen-failure branch June 30, 2020 01:14
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants