[5.5][Diagnostics] Make sure extension type repr is available before using it #37925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
Before suggesting to add `where Self == ...` condition to the extension of a protocol involved in a static member lookup, let's check whether type repr is available and valid. Resolves: rdar://78097387 (cherry picked from commit a7988b0)
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
tkremenek
approved these changes
Jun 17, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #37887
Before suggesting to add
where Self == ...condition to the extensionof a protocol involved in a static member lookup, let's check whether
type repr is available and valid.
Scope: Incorrect expressions that use static member lookup in generic context feature
but don't have appropriate extension declared (extension with concrete
Selfrequirement).Main Branch PR: [Diagnostics] Make sure extension type repr is available before using it #37887
Resolves: rdar://78097387
Risk: Low
Reviewed By: @hborla
Testing: Unfortunately no tests have been added because the issue has to do with serialized modules
which is hard to test, but it's just a nullptr check so it shouldn't be a problem.
Resolves: rdar://78097387
(cherry picked from commit a7988b0)