[cmake/AddSwift] When support is passed for LLVM_LINK_COMPONENTS also implicitly include demangle
#38913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so implicitly include `demangle` Using `support` llvm component ends up adding `-Xlinker /path/to/lib/libLLVMDemangle.a` to `LINK_FLAGS` but `libLLVMDemangle.a` is not added as an input to the linking ninja statement. As a workaround, in order to setup precise inputs for the ninja link statement, include `demangle` component whenever `support` is mentioned.
|
@swift-ci smoke test |
gottesmm
approved these changes
Aug 27, 2021
| # to `LINK_FLAGS` but `libLLVMDemangle.a` is not added as an input to the linking ninja statement. | ||
| # As a workaround, include `demangle` component whenever `support` is mentioned. | ||
| if("support" IN_LIST ASHL_LLVM_LINK_COMPONENTS) | ||
| list(APPEND ASHL_LLVM_LINK_COMPONENTS "demangle") |
There was a problem hiding this comment.
I dislike this solution since it is a bit of a hack. But I think it is fine for now.
There was a problem hiding this comment.
Thanks for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
supportllvm component ends up adding-Xlinker /path/to/lib/libLLVMDemangle.ato
LINK_FLAGSbutlibLLVMDemangle.ais not added as an input to the linking ninja statement.As a workaround, in order to setup precise inputs for the ninja link statement, include
demanglecomponentwhenever
supportis mentioned.