[CodeCompletion] Report type relations when completing inside result builders #42210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/result-builder-type-relations-solver-based
branch
from
c37d627 to
1f84ca5
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
xedin
reviewed
Apr 7, 2022
lib/Sema/ConstraintSystem.cpp
Outdated
| // it. Look for a ArgumentConversion constraint that allows us to retrieve | ||
| // the argument type var. | ||
| for (auto argConstraint : CS.getConstraintGraph().gatherConstraints( | ||
| typeVar, ConstraintGraph::GatheringKind::AllMentions)) { |
There was a problem hiding this comment.
I think you don't need AllMentions in this case or the latter one EquivalenceClass should be sufficient because the constraint in question is associated directly with the type variable the search is performed for.
There was a problem hiding this comment.
Actually it might even be enough to just iterate over direct constraints in both cases via ConstraintGraphNode::getConstraints()
xedin
reviewed
Apr 7, 2022
…completion We record fixes while solving normal expressions for code completion and we should do the same when solving result builders if we are reporting the solutions to completion callbacks.
Helped me while debugging and might help others as well.
…builders This requires navigating the constraint system solution to retrieve the argument type of the `buildBlock` call. The comments in the code should describe what I’m doing well enough. rdar://83846531
ahoppen
force-pushed
the
pr/result-builder-type-relations-solver-based
branch
from
1f84ca5 to
0b9644a
Compare
|
@swift-ci Please smoke test |
xedin
approved these changes
Apr 13, 2022
|
@swift-ci Please SourceKit stress test |
This was referenced Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires navigating the constraint system solution to retrieve the argument type of the
buildBlockcall. The comments in the code should describe what I’m doing.rdar://83846531