[CSSolver] Don't re-run solver to diagnose ambiguities #66036
+58
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While working on #66035 I noticed that |
xedin
force-pushed
the
solver-ambiguity-handling
branch
from
6458565 to
3bb865d
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
If ambiguity has been detected during normal solving, let's diagnose that right away instead of re-running the solver in diagnostic mode because it would produce exactly the same set of solutions (all solutions with fixes added in diagnostic mode would be filtered out because they'd have worse scores).
xedin
force-pushed
the
solver-ambiguity-handling
branch
from
3bb865d to
a656632
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ambiguity has been detected during normal solving,
let's diagnose that right away instead of re-running
the solver in diagnostic mode because it would produce
exactly the same set of solutions (all solutions with
fixes added in diagnostic mode would be filtered out
because they'd have worse scores).