-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[CSSolver] Don't re-run solver to diagnose ambiguities #66036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
While working on #66035 I noticed that |
6458565
to
3bb865d
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
@swift-ci please test |
@swift-ci please test source compatibility |
If ambiguity has been detected during normal solving, let's diagnose that right away instead of re-running the solver in diagnostic mode because it would produce exactly the same set of solutions (all solutions with fixes added in diagnostic mode would be filtered out because they'd have worse scores).
3bb865d
to
a656632
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
If ambiguity has been detected during normal solving,
let's diagnose that right away instead of re-running
the solver in diagnostic mode because it would produce
exactly the same set of solutions (all solutions with
fixes added in diagnostic mode would be filtered out
because they'd have worse scores).