Fix the clang dependency of sourcekit libraries. #68780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjyamauchi
requested review from
ahoppen,
bnbarham,
rintaro and
hamishknight
as code owners
compnerd
reviewed
Sep 26, 2023
Because swift_swap_compiler_if_needed updates the compiler ID to Clang, we need to account for it when deciding to add a dependency on clang. Otherwise, the sourcekit build could fail due to the clang executable not having been built there yet.
hjyamauchi
force-pushed
the
sourcekitclangdep
branch
from
38fb8ca to
71d8118
Compare
Done. PTAL. |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
compnerd
approved these changes
Oct 8, 2023
3 tasks
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
Dec 9, 2024
Because swift_swap_compiler_if_needed updates the compiler ID to Clang, we need to account for it when deciding to add a dependency on clang. Otherwise, the sourcekit build could fail due to the clang executable not having been built there yet. Cherrypick PR swiftlang#68780 Cherrypick commit 71d8118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because swift_swap_compiler_if_needed updates the compiler ID to Clang, we need to account for it when deciding to add a dependencies on clang. Otherwise, the sourcekit build could fail due to lack of clang dependency.