Support a package SILLinkage #71083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

elsh merged 1 commit into main from es-sil-pkg

Feb 7, 2024

Contributor

elsh commented Jan 23, 2024 •

edited

Loading

Decls with a package access level are currently set to public SIL linkages. This limits the ability to have more fine-grained control and optimize around resilience and serialization.
This PR introduces a separate SIL linkage and FormalLinkage for package decls, pipes them down to IRGen, and updates linkage checks to include package linkage.

Resolves rdar://121409846

elsh requested review from hborla, slavapestov, xedin, ahoppen, bnbarham, hamishknight and rintaro as code owners

January 23, 2024 04:11

elsh requested review from rjmccall, slavapestov, xymus, nkcsgexi, aschwaighofer and tshortli and removed request for xedin, slavapestov, rintaro, bnbarham, ahoppen, hborla and hamishknight

January 23, 2024 04:11

Contributor Author

elsh commented Jan 23, 2024

@swift-ci smoke test

1 similar comment

Contributor Author

elsh commented Jan 24, 2024

@swift-ci smoke test

elsh requested a review from eeckstein

January 25, 2024 15:01

elsh commented

View reviewed changes

lib/SIL/IR/SILModule.cpp Show resolved Hide resolved

elsh commented

View reviewed changes

lib/SIL/IR/SILPrinter.cpp Outdated Show resolved Hide resolved

elsh force-pushed the es-sil-pkg branch from 7896cd7 to 4b9c54b Compare

January 29, 2024 10:48

Contributor Author

elsh commented Jan 29, 2024

@swift-ci smoke test

1 similar comment

Contributor Author

elsh commented Jan 29, 2024

@swift-ci smoke test

elsh force-pushed the es-sil-pkg branch from 6ec73e5 to 7005a10 Compare

January 30, 2024 01:06

Contributor Author

elsh commented Jan 30, 2024

@swift-ci smoke test

elsh commented

View reviewed changes

test/Sema/package_resilience_access.swift Outdated Show resolved Hide resolved

elsh commented

View reviewed changes

test/SILGen/accessibility_warnings.swift Show resolved Hide resolved

elsh commented

View reviewed changes

test/Sema/package_resilience_access.swift Outdated Show resolved Hide resolved

elsh force-pushed the es-sil-pkg branch 2 times, most recently from fd29f75 to 005d1ba Compare

January 31, 2024 15:33

Contributor Author

elsh commented Jan 31, 2024

@swift-ci test source compatibility

1 similar comment

Contributor Author

elsh commented Jan 31, 2024

@swift-ci test source compatibility

elsh changed the title ~~Introduce new SILLinkage and FormalLinkage for package decls.~~ Support a package SILLinkage

eeckstein reviewed

View reviewed changes

Contributor

eeckstein left a comment

The SIL part LGTM!

include/swift/SIL/SILLinkage.h Outdated Show resolved Hide resolved

Contributor Author

elsh commented Feb 1, 2024

@swift-ci test source compatibility

elsh force-pushed the es-sil-pkg branch from 84d00d7 to f3eceb0 Compare

February 6, 2024 08:59


          Support package SIL linkage.

72a7760

Decls with a package access level are currently set to public SIL
linkages. This limits the ability to have more fine-grained control
and optimize around resilience and serialization.
This PR introduces a separate SIL linkage and FormalLinkage for
package decls, pipes them down to IRGen, and updates linkage checks
at call sites to include package linkage.

Resolves rdar://121409846

elsh force-pushed the es-sil-pkg branch from f3eceb0 to 72a7760 Compare

February 6, 2024 09:24

Contributor Author

elsh commented Feb 6, 2024

@swift-ci test source compatibility

1 similar comment

Contributor Author

elsh commented Feb 6, 2024

@swift-ci test source compatibility

Contributor Author

elsh commented Feb 6, 2024

@swift-ci smoke test

Contributor Author

elsh commented Feb 7, 2024

CI source compat suite failure below is a known issue on main branch (#71423) / rdar://122427719 and is unrelated to this PR.

========================================
XFailures:
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.2, 286360, CoreStore watchOS, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.2, 286360, CoreStore tvOS, generic/platform=tvOS
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.2, 286360, CoreStore OSX, generic/platform=macOS
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.2, 286360, CoreStore iOS, generic/platform=iOS
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.0, 83e608, CoreStore watchOS, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.0, 83e608, CoreStore tvOS, generic/platform=tvOS
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.0, 83e608, CoreStore OSX, generic/platform=macOS
  XFAIL: https://github.com/apple/swift/issues/70742, CoreStore, 4.0, 83e608, CoreStore iOS, generic/platform=iOS
  XFAIL: https://github.com/apple/swift/issues/69410, Kingfisher, 5.0, 44450a, Kingfisher, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/65197, ProcedureKit, 5.0, a7fa56, ProcedureKit, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/65197, ProcedureKit, 4.2, 94193d, ProcedureKit, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/65197, PromiseKit, 5.0, 8e5f5d, PromiseKit, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/65197, PromiseKit, 4.0, c538a2, PromiseKit, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/65204, R.swift, 5.0, f96758, Swift Package
  XFAIL: https://github.com/apple/swift/issues/65204, R.swift, 4.2, f96758, Swift Package
  XFAIL: https://github.com/apple/swift/issues/70744, ReactiveSwift, 5.0, e60a8b, ReactiveSwift-watchOS, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/70744, ReactiveSwift, 4.0, 46fb4d, ReactiveSwift-watchOS, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/70970, Result, 5.0, c30700, Swift Package
  XFAIL: https://github.com/apple/swift/issues/65202, swift-protobuf-plugin-example, 5.0, 85bec0, Swift Package
  XFAIL: https://github.com/apple/swift/issues/65197, mapper, 5.0, 877dc5, Mapper, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/65197, mapper, 4.2, d501cb, Mapper, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/65197, mapper, 4.0, d501cb, Mapper, generic/platform=watchOS
  XFAIL: https://github.com/apple/swift/issues/57431, siesta, 5.0, cb9c1b, Swift Package
========================================
Failures:
  FAIL: penny-bot, 5.9, 62006b, Swift Package
========================================
Action Summary:
     Passed: 346
     Failed: 1
    XFailed: 23
    UPassed: 0
      Total: 370
========================================
Repository Summary:
      Total: 123
========================================
Result: FAIL
========================================

https://ci.swift.org/job/swift-PR-source-compat-suite-debug-macos/1378/console
https://ci.swift.org/job/swift-PR-source-compat-suite-macos/1383/console

elsh merged commit e38bc97 into main

elsh deleted the es-sil-pkg branch

February 7, 2024 00:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eeckstein eeckstein left review comments

rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

xymus Awaiting requested review from xymus xymus is a code owner

nkcsgexi Awaiting requested review from nkcsgexi

aschwaighofer Awaiting requested review from aschwaighofer

tshortli Awaiting requested review from tshortli

Labels

None yet