Implement Value generics #75518
Implement Value generics #75518
Conversation
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Azoy
force-pushed
the
integer-generics
branch
2 times, most recently
from
09935be to
f5408c9
Compare
|
@swift-ci please smoke test |
|
swiftlang/llvm-project#9030 |
|
Please test with following pull request: @swift-ci please smoke test |
2 similar comments
|
Please test with following pull request: @swift-ci please smoke test |
|
Please test with following pull request: @swift-ci please smoke test |
Azoy
requested review from
rjmccall,
hborla,
xedin,
slavapestov,
xymus,
jckarter,
ahoppen,
bnbarham,
CodaFi,
hamishknight,
rintaro,
mikeash,
al45tair and
AnthonyLatsis
as code owners
Azoy
force-pushed
the
integer-generics
branch
from
b540d78 to
17eb973
Compare
|
Please test with following pull request: @swift-ci please test |
|
Please test with following pull request: @swift-ci please test Windows |
1 similar comment
|
Please test with following pull request: @swift-ci please test Windows |
The test was failing on 32-bit platforms after swiftlang#75518
| // Eat any '-' preceding the type. | ||
| SourceLoc minusLoc; | ||
| if (Tok.isMinus()) { | ||
| minusLoc = consumeToken(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this mean that we drop the - in all cases where it’s not followed by an integer literal? So, does this mean that the following code is now valid?
let x: -String = 2There was a problem hiding this comment.
Yeah, this is an issue. I'll make a change that only eats preceding - if the following token is an integer literal.
| @@ -1574,7 +1588,7 @@ bool Parser::canParseType() { | |||
| return false; | |||
| break; | |||
| case tok::oper_prefix: | |||
| if (Tok.getText() != "~") { | |||
| if (Tok.getText() != "~" && Tok.getText() != "-") { | |||
There was a problem hiding this comment.
Similar here, does this mean that we return true from canParseType for -String?
This implements the feature described in the GenericsManifesto here: https://github.com/swiftlang/swift/blob/main/docs/GenericsManifesto.md#generic-value-parameters
One can introduce a value generic parameter by marking the type
letin the generic parameter clause:and you must declare the value type that this is a value for. At the moment this is limited to
Int(but I've left the door open to "easily" expanding it for potential future directions). You can specialize a type with a value generic with an integer literal or by passing another value generic with the same underlying value type:This is still a WIP.