[test] Run Python unit tests in validation tests #778
Conversation
|
@modocache Thank you! Could you instead integrate tests through lit? That is, via a file with a |
|
Gyb has doctests too; you might want to run those |
modocache
force-pushed
the
add-python-unit-tests-to-build
branch
from
6bf7cc6 to
3e7b4f6
Compare
|
@dabrahams I noticed this CMake file, which purports to add a @gribozavr I updated the PR to use |
|
@modocache Oh, I see -- it seems like the |
|
@modocache Thanks! I don't think you need to go as far as creating a new directory, and a readme. You can just add a new file |
|
@modocache If we have a separate phase for tests of python scripts, it would be better to test gyb there, rather than running its tests each time it processes a file, right? |
I think so as well. I'd add it to this pull request, but I'm still trying to figure out how to run the |
modocache
force-pushed
the
add-python-unit-tests-to-build
branch
from
3e7b4f6 to
af1cd9a
Compare
|
@gribozavr Updated as per your comments. 👍 |
|
@modocache Thank you, almost perfect! Please add the new substitution to |
This repository includes several Python modules, each with unit tests. Add a step to the validation tests to ensure these tests pass.
modocache
force-pushed
the
add-python-unit-tests-to-build
branch
from
af1cd9a to
0ede0c4
Compare
|
@gribozavr Oh, good catch!! Thanks. Updated! |
[test] Run Python unit tests in validation tests
|
Thanks! |
swift-corelibs-xctest uses a Python program called xctest_checker to run its functional test suite. That program itself has unit tests, written in Python. These unit tests should be run as part of the greater XCTest test suite. This is probably possible by modifying the lit.cfg in the swift-corelibs-xctest project such that it picks up on a file with a RUN: directive that triggers the Python tests. See swiftlang/swift#778 for an example. See llvm.org/docs/CommandGuide/lit.html for additional details on lit--it's the test runner for Swift, LLVM, and other projects, so it's nice to know about it.
swift-corelibs-xctest uses a Python program called xctest_checker to run its functional test suite. That program itself has unit tests, written in Python. These unit tests should be run as part of the greater XCTest test suite. This is probably possible by modifying the lit.cfg in the swift-corelibs-xctest project such that it picks up on a file with a RUN: directive that triggers the Python tests. See swiftlang/swift#778 for an example. See llvm.org/docs/CommandGuide/lit.html for additional details on lit--it's the test runner for Swift, LLVM, and other projects, so it's nice to know about it.
[pull] swiftwasm-release/5.3 from release/5.3
This repository includes several Python modules, each with unit tests.
Add a step to the validation tests to ensure these tests pass.
For now, there's only one module being tested:
cmpcodesize. #761 adds unit tests for several components ofutils/build-script, and I plan to add those tests to this command as well.