From 574da8aa53d7791fa16ec046e65dd9285bb25f8a Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Thu, 16 Jan 2025 00:49:31 +0300 Subject: [PATCH] [AutoDiff] Delete wrong FIXMEs (TF-284) from tests In AutoDiff/Sema/differentiable_attr_type_checking.swift, we have a couple of following FIXMEs: ``` // FIXME(TF-284): Fix unexpected diagnostic. ``` However, the diagnostic is expected for the case of public protocol requirements: see description https://github.com/swiftlang/swift/pull/30629. This PR removed the diagnostic for less-than-public-visible requirements, and the FIXME was initially related to them. It looks like that the FIXMEs present now are a result of copy-paste and have no meaning, and the diagnostic is expected and should be present and does not need to be removed. Fixes #78609 --- test/AutoDiff/Sema/differentiable_attr_type_checking.swift | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/AutoDiff/Sema/differentiable_attr_type_checking.swift b/test/AutoDiff/Sema/differentiable_attr_type_checking.swift index fee01275f6bf1..98ff06879396e 100644 --- a/test/AutoDiff/Sema/differentiable_attr_type_checking.swift +++ b/test/AutoDiff/Sema/differentiable_attr_type_checking.swift @@ -290,7 +290,6 @@ public struct PublicDiffAttrConformance: ProtocolRequirements { var x: Float var y: Float - // FIXME(TF-284): Fix unexpected diagnostic. // expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }} // expected-note @+1 {{candidate has non-matching type '(x: Float, y: Float)'}} public init(x: Float, y: Float) { @@ -298,7 +297,6 @@ public struct PublicDiffAttrConformance: ProtocolRequirements { self.y = y } - // FIXME(TF-284): Fix unexpected diagnostic. // expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }} // expected-note @+1 {{candidate has non-matching type '(x: Float, y: Int)'}} public init(x: Float, y: Int) {