Skip to content

[CMake] Fix missing RegexParser dependency #80362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link
Member

RegexBuilder depends on RegexParser. Without the link dependency, we the swift module isn't passed to the RegexBuilder build.

RegexBuilder depends on RegexParser. Without the link dependency, we the
swift module isn't passed to the RegexBuilder build.
@etcwilde
Copy link
Member Author

@swift-ci please smoke test

@etcwilde
Copy link
Member Author

Windows Failure:

T:\PythonAMD64-3.9.10\tools\include\pyconfig.h(190): error C2371: 'pid_t': redefinition; different basic types
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\llvm-project\lldb\include\lldb/Host/windows/PosixApi.h(80): note: see declaration of 'pid_t'

@etcwilde
Copy link
Member Author

Windows should be fixed by swiftlang/llvm-project#10369

@etcwilde
Copy link
Member Author

@swift-ci please test Windows

@etcwilde etcwilde merged commit ce4ef8d into swiftlang:main Mar 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants