Optimizer: Improve performance of large InlineArrays at Onone #81706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
jckarter,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
AnthonyLatsis,
rjmccall and
adrian-prantl
as code owners
eeckstein
requested review from
atrick,
meg-gupta and
nate-chandler
and removed request for
rjmccall,
Xazax-hun,
adrian-prantl,
egorzhdan,
j-hui,
zoecarver,
hnrklssn,
AnthonyLatsis,
fahadnayyar and
susmonteiro
|
@swift-ci test |
atrick
reviewed
May 23, 2025
* Move the mutating APIs into Context.swift, because SIL can only be mutated through a MutatingContext * move the `baseOperand` and `base` properties from the instruction classes to the `MarkDependenceInstruction` protocol * add `valueOrAddressOperand` and `valueOrAddress` in the `MarkDependenceInstruction` protocol
* re-implement the SILCombine peephole as a Swift instruction simplification * run this simplification also in the OnoneSimplification pass
This is a workaround for a bug in the move-only checker: rdar://151841926. The move-only checker sometimes inserts destroy_addr within read-only static access scopes. Therefore don't consider static access scopes as immutable scopes.
Introduce a new pass MandatoryTempRValueElimination, which works as the original TempRValueElimination, except that it does not remove any alloc_stack instruction which are associated with source variables. Running this pass at Onone helps to reduce copies of large structs, e.g. InlineArrays or structs containing InlineArrays. Copying large structs can be a performance problem, even at Onone. rdar://151629149
eeckstein
force-pushed
the
mandatory-temprvalue-elimination
branch
from
efc01b8 to
198d4ab
Compare
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
@swift-ci clean apple silicon benchmark |
|
@swift-ci benchmark |
|
@swift-ci apple silicon benchmark |
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to avoid copying large InlineArrays at Onone, because even for Onone the performance suffers too much if such copies are not eliminated.
The solution to this to run the TempRValueElimination at Onone.
In this PR I added a new MandatoryTempRValueElimination pass, which works as the original TempRValueElimination, except that it does not remove any alloc_stack instruction which are associated with source variables.
In addition it's required to simplify
mark_dependenceinstructions at Onone. I re-implement the SILCombine peephole as a Swift instruction simplification and let run this simplification also in the OnoneSimplification pass.rdar://151629149