[wasm] Build and install Foundation for Wasm SDK #82285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
MaxDesiatov
reviewed
Jun 17, 2025
Comment on lines
214
to
215
| self._build_libxml2(swift_host_triple, has_pthread, wasi_sysroot) | ||
| self._build_foundation(swift_host_triple, has_pthread, wasi_sysroot) |
There was a problem hiding this comment.
Is Foundation built for any other platform for smoke test CI trigger? If not, I think we should make _build_libxml2 and _build_foundation conditional on --foundation passed to build-script or included in a preset
There was a problem hiding this comment.
Smoke test builds Foundation for the host platform as well.
|
@swift-ci smoke test macos |
MaxDesiatov
approved these changes
Jun 17, 2025
MaxDesiatov
added
Foundation
WebAssembly
kateinoigakukun
force-pushed
the
yt/build-foundation
branch
from
c99d60e to
81b908e
Compare
|
@swift-ci smoke test Linux platform |
|
@swift-ci build toolchain |
|
@swift-ci smoke test |
kateinoigakukun
force-pushed
the
yt/build-foundation
branch
from
81b908e to
838e954
Compare
|
@swift-ci build toolchain |
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
kateinoigakukun
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
This was referenced Jul 10, 2025
MaxDesiatov
added a commit
that referenced
this pull request
Jul 17, 2025
) Cherry-pick of #82285, merged as 05204bd **Explanation**: Include Swift Testing Foundation and libxml2 into the Swift SDK for WebAssembly **Scope**: Limited to Swift SDK for Wasm **Risk**: Low, due to limited scope. Changes were incubated on `main` for 2 weeks with no known issues. Swift Testing changes were incubated for more than a month. **Testing**: Manual testing with Swift SDKs produced off `main`. **Issue**: rdar://155865189 **Reviewer**: @MaxDesiatov --------- Co-authored-by: Yuta Saito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Foundation and libxml2 into the Swift SDK for WebAssembly