Skip to content

[Dependency Scanning][C++ Interop] Do not skip lookup of 'CxxStdlib' overlay for the source module #82751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 2, 2025

A prior change ensured that we forego this query when looking up Swift overlays for a textual interface which was built without C++ interop. This change introduced a bug where it also caused us to skip this lookup for the main source module. This commit resolves that by preserving the fix above but also ensuring we perform the lookup for the main source module under scan.

…overlay for the source module

A prior change ensured that we forego this query when looking up Swift overlays for a textual interface which was built without C++ interop. This change introduced a bug where it also caused us to skip this lookup for the main source module. This commit resolves that by preserving the fix above but also ensuring we perform the lookup for the main source module under scan.
@artemcm artemcm requested review from nkcsgexi, egorzhdan and j-hui July 2, 2025 22:52
@artemcm artemcm requested a review from cachemeifyoucan as a code owner July 2, 2025 22:52
@artemcm
Copy link
Contributor Author

artemcm commented Jul 2, 2025

@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Jul 3, 2025

@swift-ci smoke test Windows platform

@artemcm artemcm added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 and removed 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jul 3, 2025
@artemcm artemcm merged commit d499b14 into swiftlang:main Jul 7, 2025
3 checks passed
@artemcm artemcm deleted the FixDepScanCxxStdlibLookup branch July 7, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants