build-script: allow --test-wasm-stdlib without --build-wasm-stdlib
#83135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows testing Wasm stdlib without rebuilding WASI sysroot and stdlib, while some changes are still detected by ninja as dependencies and are rebuilt, which is great for local incremental builds.
MaxDesiatov
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
MaxDesiatov
added
test suite
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
I'd like to suggest we consider the root cause approach here. The underlying problem appears to be overly conservative incremental builds in wasi-libc that trigger full stdlib rebuilds. There's actually a fix for this root issue in wasi-libc: WebAssembly/wasi-libc@eadb436 While this approach could work as a temporary solution until the wasi-libc fix is released, I wonder if we might first explore cherry-picking that wasi-libc patch locally? This would allow us to maintain consistency with other products in build-script without hacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows testing Wasm stdlib without fully rebuilding WASI sysroot and stdlib, while changes to stdlib itself are still detected by ninja as dependencies and are built incrementally, which is great for local builds.