Let Character literals, which fit into 64 bits, be folded into a single integer constant. #9225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e optimizer to remove a result of a computation. It’s similar to the _blackHole function in the stdlib unit tests.
…er results in the CharacterLiteralsSmall benchmark.
…le integer constant. This is done by ensuring that the corresponding Character constructor is inlined. llvm will do the constant folding. Also add a test which checks this. It makes character literals much faster (3x improvement for the CharacterLiteralsSmall benchmark) And it removes _a lot_ of redundant code (~80% for the CharacterLiteralsSmall benchmark)
|
@swift-ci Please smoke test |
|
@swiftix Can you please take a look at the stdlib changes? |
|
@eeckstein Overall, it looks good. Have you looked at the code size of the stdlib and benchmark executables after this change? What are the numbers? |
|
No significant changes on code size, except -80% on CharacterLiteralsSmall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by ensuring that the corresponding Character constructor is inlined. llvm will do the constant folding.
Also add a test which checks this.
It makes character literals much faster (3x improvement for the CharacterLiteralsSmall benchmark)
And it removes a lot of redundant code (~80% for the CharacterLiteralsSmall benchmark)
rdar://problem/22481219