-
Notifications
You must be signed in to change notification settings - Fork 80
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Enable the check for unacceptable language after fixing the issues below:
Run curl -s https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/scripts/check-unacceptable-language.sh | bash
curl -s https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/scripts/check-unacceptable-language.sh | bash
shell: /usr/bin/bash -e {0}
env:
UNACCEPTABLE_WORD_LIST: blacklist whitelist slave master sane sanity insane insanity kill killed killing hang hung hanged hanging
** Checking for unacceptable language...
** ERROR: ❌ Found unacceptable language:
CHANGELOG.md:330:3:- Killing of `xctest` process if testing is cancelled.
CHANGELOG.md:590:84:- Cancellation support for tests. When you cancel a test the underlying process is killed (previously it was left running).
CHANGELOG.md:597:78:- Run non-debug test sessions outside of debugger. Now a crash test will not hang inside the debugger. Also we can stream test output to the test explorer view.
CONTRIBUTING.md:17:98:More details on nvm installation can be found in the [README](https://github.com/nvm-sh/nvm/blob/master/README.md) from its GitHub repository.
NOTICE.txt:37:51: * https://github.com/vadimcn/vscode-lldb/blob/master/LICENSE
src/TestExplorer/TestExplorer.ts:252:73: // normally we wouldn't run the build here, but you can hang swiftPM on macOS
src/tasks/SwiftProcess.ts:64:19: * Forcefully kill the pty process. Optionally can provide a signal.
src/tasks/SwiftProcess.ts:66:5: kill(signal?: NodeJS.Signals): void;
src/tasks/SwiftProcess.ts:132:5: kill(signal?: NodeJS.Signals): void {
src/tasks/SwiftProcess.ts:136:29: this.spawnedProcess.kill(signal);
src/tasks/SwiftPseudoterminal.ts:84:22: * ex. ctrl+c to kill, and otherwise pass the input along
src/tasks/SwiftPseudoterminal.ts:91:12: // Kill on ctrl+c
src/tasks/SwiftPseudoterminal.ts:93:31: this.swiftProcess.kill();
src/tasks/SwiftPseudoterminal.ts:108:27: this.swiftProcess.kill();
src/utilities/utilities.ts:163:19: p.kill(killSignal);
test/MockUtils.ts:121:43: // throw an error if not set. Hang onto the error and throw it later
test/fixtures.ts:75:5: kill(): void {
Error: Process completed with exit code 1.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
Done