This repository was archived by the owner on Sep 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 156
Updated routing auto documentation for 1.0 #511
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dantleech
commented
Jul 1, 2014
Q | A |
---|---|
Doc fix? | no |
New docs? | yes |
Applies to | 1.0 |
Fixed tickets |
<defunct-route-handler name="leave_redirect" /> | ||
</mapping> | ||
</auto-mapping> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many lines
Missing the token providers section |
single: Conflict Resolvers; RoutingAutoBundle | ||
|
||
Conflict Resolvers | ||
------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one dash to much
Updated - added missing token providers section and travis should pass. |
We need to include a section on configuring the bundle. The new version requires that PHPCR be enabled specifically before anything works. |
Updated, I would also be +1 for merging this. |
You can merge this when symfony-cmf/routing-auto#9 is merged imo. I'll read the online version and make changes afterwards, it's too hard to review it in the diff :) |
wouterj
added a commit
that referenced
this pull request
Aug 11, 2014
Updated routing auto documentation for 1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.