This repository was archived by the owner on Sep 16, 2021. It is now read-only.
add book into bundles doc #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectricMaxxx
suggested changes
Aug 21, 2017
There was a problem hiding this comment.
Looks fine for me.
- can you also have a look that we do not have a kind of a build script, that requires the book content?
- do we have a link from index into the book?
Otherwise we should simply merge and go through the result again, which sould be smaller then before.
dbu
force-pushed
the
book-into-bundles
branch
3 times, most recently
from
a7b7fb8 to
879e1cc
Compare
|
ok, changed all references to the book to better links, and removed a few. |
This was referenced Aug 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #828