This repository was archived by the owner on Jan 1, 2023. It is now read-only.
Skip assets created by the assetic.asset DI tag in the routing #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
changed the title
|
Thanks @pvolok. |
stof
added a commit
that referenced
this pull request
Oct 14, 2014
…ng (pvolok) This PR was merged into the 2.4-dev branch. Discussion ---------- Skip assets created by the assetic.asset DI tag in the routing I'm adding assetic tags to the [Symfony reference](http://symfony.com/doc/master/reference/dic_tags.html). For the ``assetic.asset`` tag, the only use case I can think of is: ``` yaml services: my_asset: class: Assetic\Asset\StringAsset arguments: [ 'alert("Hey dawg!");' ] tags: - { name: assetic.asset, alias: my_asset } ``` ```twig {% javascripts '@my_asset' %} <script src="{{ asset_url }}"></script> {% endjavascripts %} ``` But this code produces an error in ``Symfony\Bundle\AsseticBundle\Routing::load()``. It happens because this method tries to get a formula for every asset, while our asset doesn't have a formula. This PR skips assets without formulae. Commits ------- 74cf3f7 Skip formula-less assets in routing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding assetic tags to the Symfony reference. For the
assetic.assettag, the only use case I can think of is:{% javascripts '@my_asset' %} <script src="{{ asset_url }}"></script> {% endjavascripts %}But this code produces an error in
Symfony\Bundle\AsseticBundle\Routing::load(). It happens because this method tries to get a formula for every asset, while our asset doesn't have a formula. This PR skips assets without formulae.