Use %CONFIG_DIR% in ContainerConfigurator?

[simshaun]

Hi,

I am organizing my backend (Symfony) and frontend (JS/SCSS/etc) files in two separate folders, with composer.json and other stuff at the root of the project. (Note: backend and frontend are only for file organization. Symfony will still be rendering most of the frontend, so it's not like its two separate apps.)

So, I've got backend/bin/, backend/config/, backend/src/, etc. I configured composer.json to set "config-dir": "backend/config". That has worked fine for installing several bundles.

However, trying to composer req validator, I get the error:

file(E:\_projects\foo/config/services.yaml): failed to open stream: No such file or directory

Looking at the ContainerConfigurator, it's using getcwd().'/config/services.yaml'.

Compare that to the BundleConfigurator which uses $this->options->expandTargetDir('%CONFIG_DIR%/bundles.php').

I think the ContainerConfigurator should also use the config-dir param. Right? I'll open a PR if so.

[Pierstoval]

I think you're right, experts might come after me with wiser words, but I think it's ok to create a PR with this 😄

[fabpot]

Looks like we are using a lot of harcoded 'config/' in Flex. @simshaun Can work on a PR to fix them all?

[VolCh]

Also looks like we are using a lot of 'hardcoded' getcwd() not only with '/config':

flex/src/Configurator/MakefileConfigurator.php

Line 33 in bafa430

file_put_contents(getcwd().'/Makefile', <<<EOF

flex/src/Configurator/GitignoreConfigurator.php

Line 25 in b22b02a

$gitignore = getcwd().'/.gitignore';

flex/src/Configurator/CopyFromRecipeConfigurator.php

Line 24 in dc4b6fb

$this->copyFiles($config, $recipe->getFiles(), getcwd());

But we haven't something like 'flex-root-dir' in Flex::initOptions() to use as base in Options::expandTargetDir() for project root file like .gitignore. Maybe it makes sense to define it with default getcwd() and use only Options::expandTargetDir() for paths?

[simshaun]

@fabpot I'll try to work on a PR within the next few days.

[simshaun]

Ok, so I started a PR to fix the ContainerConfigurator, but I'm not sure what to do with all the other instances of getcwd(). They are being used in cases like @VolCh mentioned. Does there need to be a new config option called root-dir or something like that?

I personally always have composer.json at the same level as .env, .gitignore, Makefile, etc.... But, maybe somebody doesn't and would need it to be configurable.