Add info about storing remember me tokens in a database #11392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Apr 10, 2019
pierredup
force-pushed
the
remember-me-token-provider
branch
from
2326e5d to
311543f
Compare
| ------------------------------------------ | ||
|
|
||
| By default, tokens are stored in a cookie. You can choose to store the token in a database, | ||
| to not have a (hashed) version of the password in a cookie. |
There was a problem hiding this comment.
why (hashed) with parenthesis?
also, is it really the password? or like an hash?
There was a problem hiding this comment.
why (hashed) with parenthesis?
This was just copied from the original description, I'm not sure why the parenthesis is needed
also, is it really the password? or like an hash?
It's a hashed version of the password
javiereguiluz
added a commit
that referenced
this pull request
Apr 12, 2019
…(pierredup) This PR was merged into the 3.4 branch. Discussion ---------- Add info about storing remember me tokens in a database I only recently saw that the remember me functionality has a `token_provider` option, and there is a default class to store tokens in the database as part of the DoctrineBridge, however there is no clear information on how this provider should be used (the class itself contains some hints, but the `token_provider` setting wasn't clear which values it accepts). So I want to add a section to the remember me docs to explain how to use the `DoctrineTokenProvider`, which might also give some hints on how to create a custom provider Commits ------- 311543f Add info about storing remember me tokens in a database
|
@pierredup I didn't know about this feature ... so thanks a lot for contributing these docs and for teaching me about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only recently saw that the remember me functionality has a
token_provideroption, and there is a default class to store tokens in the database as part of the DoctrineBridge, however there is no clear information on how this provider should be used (the class itself contains some hints, but thetoken_providersetting wasn't clear which values it accepts).So I want to add a section to the remember me docs to explain how to use the
DoctrineTokenProvider, which might also give some hints on how to create a custom provider