From 0dc5efcd698eb1a3afcade0be727c0255bc05f71 Mon Sep 17 00:00:00 2001 From: Felix SOEDJEDE Date: Tue, 7 Apr 2020 10:38:40 +0200 Subject: [PATCH] [Contributing] Fix `trigger_error()` position in deprecated class The code was added in commit: https://github.com/symfony/symfony-docs/commit/a2c04e717d7e70b485ef1a62fb5231e71add3ee2 The change introducing the issue was added in the PR: https://github.com/symfony/symfony-docs/pull/12075 --- contributing/code/conventions.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/code/conventions.rst b/contributing/code/conventions.rst index 7099ace5db5..05dff1ebf61 100644 --- a/contributing/code/conventions.rst +++ b/contributing/code/conventions.rst @@ -129,7 +129,7 @@ the Web Debug Toolbar or by the PHPUnit bridge). .. _`@-silencing operator`: https://php.net/manual/en/language.operators.errorcontrol.php When deprecating a whole class the ``trigger_error()`` call should be placed -between the namespace and the use declarations, like in this example from +after the use declarations, like in this example from `ServiceRouterLoader`_:: namespace Symfony\Component\Routing\Loader\DependencyInjection;