From 7572fcb1ece0522b9f637e513a2b591e5b7617a0 Mon Sep 17 00:00:00 2001 From: Carl-Philipp Jung Date: Wed, 8 Apr 2020 17:22:44 +0200 Subject: [PATCH] Corrects description for placement of trigger_deprecation() --- contributing/code/conventions.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/code/conventions.rst b/contributing/code/conventions.rst index 1f194437744..246634dc39f 100644 --- a/contributing/code/conventions.rst +++ b/contributing/code/conventions.rst @@ -122,7 +122,7 @@ A deprecation must also be triggered to help people with the migration trigger_deprecation('symfony/package-name', '5.1', 'The "%s" class is deprecated, use "%s" instead.', Deprecated::class, Replacement::class); When deprecating a whole class the ``trigger_deprecation()`` call should be placed -between the namespace and the use declarations, like in this example from +between the use declarations and the class, like in this example from `ServiceRouterLoader`_:: namespace Symfony\Component\Routing\Loader\DependencyInjection;