Use useQueryCache #36
Conversation
Uses useQueryCache instead of the default cache to enable the dev tools if useQuery is used throughout the code base.
|
This will require a version bump to at least React Query 1.5.0 |
Is that desired or do you want to keep the dev-tools available for all version (1.0.0)? |
|
Technically we would also have to do a major semver bump here too.
…On Jun 18, 2020, 2:07 AM -0600, Domino987 ***@***.***>, wrote:
> This will require a version bump to at least React Query 1.5.0
Is that desired or do you want to keep the dev-tools available for all version (1.0.0)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Yes that's true. But currently using useQuery cannot be used for the dev tools which is unfortunate. |
|
Looks like we’ll have to handle both versions
…On Jun 18, 2020, 2:17 AM -0600, Domino987 ***@***.***>, wrote:
Yes that's true. But currently using useQuery cannot be used for the dev tools which is unfortunate.
So are there any concerns regarding bumping the react-query version up and doing a semver bump?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Is it possible to check if useQuery is exported form react-query (v1.5) and use that. Or else fall back to use the queryCache exported anyway? |
|
conditionally calling |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
It may look like a breach of the rules, but it’s legit. If it’s exported, it will always be called. Otherwise, fall back to the global, which since its a global, no need for it to be in the dependency array |
Uses useQueryCache instead of the default cache to enable the dev tools if useQuery is used throughout the code base.
This will show now all queries in the dev-tools instead of only the queries not wrapped in a CacheProvider.