This repository was archived by the owner on Jan 2, 2021. It is now read-only.
v3 support #81
Merged
v3 support #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and extracted the queryCache from the queryClient I also removed the fallback because with v3, you always need to wrap your app in a QueryClientProvider
but we don't really care about the argument because we have the queryCache in the closure
|
@tannerlinsley This obviously shouldn't go to master, but there isn't really a v3 branch yet 🤷 |
TkDodo
commented
Nov 13, 2020
| @@ -65,6 +65,7 @@ | |||
| "prettier": "^1.19.1", | |||
| "react": "^16.12.0", | |||
| "react-dom": "^16.12.0", | |||
| "react-query": "^3.2.0-beta.23", | |||
There was a problem hiding this comment.
not sure if it's a good idea to also add react-query to the dev-dependencies, but it gave me auto-complete when importing from it :)
|
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #78
This pull request makes the react-query-devtools work with the latest v3 beta