Web Compatibility Issue: Sugar versions v0.9 through v1.3.9 (inclusive)

[codehag]

Hi,

Unfortunately, we have found a web compat issue with the sugar.js library. Details here: https://bugzilla.mozilla.org/show_bug.cgi?id=1750812#c5

I didn't check all possible versions for breakage. For sure it is broken on 1.1.2, it looks (from reading the code) that it is fixed by 1.5.

I will add a pref on nightly to allow our users to keep working, and see how broad this issue is. Maybe if it is just a few consumers we can get around it...

[Andrew-Cottrell]

There is a note in Sugar/CAUTION.md that indicates the override fix may be present since v1.4.0.

Version 1.4.0 improves future-compatibility by ensuring that browser updates do not cause breakages going forward.

I think the fix was implemented in andrewplummer/Sugar@bc189b4 by setting override to true when calling function extend in "lib/core.js".

It may be easier for consumers to update to v1.4.0 rather than v1.5.0, however there are breaking changes in either case.

[codehag]

fantastic, thank you @Andrew-Cottrell -- It will depend on how wide spread this is ... but hopefully we can work with people to update and manage to keep the name.

[CarterLi]

Another option: Can we accept string as the first argument? It's useful to simplify code

[
  { name: 'a', sex: 'F' },
  { name: 'b', sex: 'M' },
  { name: 'c', sex: 'F' },
].groupBy('sex')

// https://lodash.com/docs/4.17.15#groupBy
['one', 'two', 'three'].groupBy('length');

[noppa]

That alone wouldn't fix the compatibility issue, the sugarjs version also takes a second argument, a function that gets called for each group.

[codehag]

We have another failure: webcompat/web-bugs#98458

[bathos]

Is this a case where dropping the preposition would help, or is group also known to have collision issues?

It doesn't seem like group alone loses much clarity. It might even be clearer for some people (thinking about stuff @hax said about the value of simple names for ESL folks) and could address the use of ByTo that a number of folks found unnatural. (Apologies if this was already considered, I didn't see it when I searched tho apart from being mentioned in passing in the ByTo thread.)

[codehag]

We will have to check if there are collisions on other names -- adding new prototype methods to array often runs into this. But, yes, I am starting to think we may need a rename if we find more sites are failing.

In the ideal case, we will be able to resolve them like we did with at(). In that case, after the name change we still had a naming conflict, but it was a single app specific library that was failing. I am afraid we are not so fortunate here. sugar.js is calling groupBy during initialization, so it will happen for every importer of this library regardless of if they use groupBy in their code or not.

[domenic]

Not sure if it's time to start throwing out other name suggestions yet, but one idea is groupedBy().

[syg]

Subscribing to keep up with resolution attempts, and holding off shipping in V8 in the meantime.

[ljharb]

“old versions of sugar” seems like a feasible-but-large evangelism task; I’m still hopeful we’ll be able to keep the existing names.

[jridgewell]

groupedBy isn't terrible, but it's unfortunate we're having this clash. Given this error will trigger on every site that uses older Sugar, I'm not sure we'll be able to get everyone to update. How do we even query for sites that use it?

[rauschma]

More name ideas:

• .groupToObject()
• .groupToMap()

[jridgewell]

Querying the HTTP Archive, there appear to be around 1100 origins using 2000 payloads that contain SugarMethods:

SELECT
  page,
  COUNT(*) AS volume
FROM (
  SELECT * FROM `httparchive.response_bodies.2022_01_01_desktop`
  UNION ALL SELECT * FROM `httparchive.response_bodies.2022_01_01_mobile`
)
WHERE body LIKE "%SugarMethods%"
GROUP BY 1
ORDER BY 2 DESC

first 100 origins

page	volume
https://www.sanito.pl/	4
https://apply.interfolio.com/	4
https://crocsegypt.com/	4
http://www.hotel-ichii.co.jp/	4
https://retrievals.echecks.com/	4
https://hotels.webjet.co.nz/	4
https://www.crocsegypt.com/	4
https://my.echecks.com/	4
https://jisho.org/	2
https://szajnochy.upmenusite.com/	2
https://www.kucak.pl/	2
https://www.materiaprimasuplementos.com.br/	2
https://www.schoolinthesquare.org/	2
https://www.spero.academy/	2
https://www.ssp.rs.gov.br/	2
http://gaia.inegi.org.mx/	2
https://www.imtenan.com/	2
http://www.pocolocokrakow.pl/	2
https://www.citizensrewards.com/	2
https://www.district30.org/	2
https://www.d114.org/	2
https://weekly-residence.com/	2
https://www.app.luggagefree.com/	2
https://www.decaturproud.org/	2
https://www.knoxville.k12.ia.us/	2
https://app.expenseon.com/	2
https://www.cinepolisklic.com/	2
https://www.pizzanawypasie.eu/	2
https://saude.rs.gov.br/	2
https://www.contractorsplan.com/	2
https://www.piasabirds.net/	2
https://okumaresort.com/	2
https://www.atlantica.se/	2
https://www.ladoatleta.com.br/	2
https://procon.rs.gov.br/	2
https://www.youmiko.pl/	2
https://www.pointquestrewards.com/	2
https://ru.poetree.club/	2
https://www.harusushi.pl/	2
https://mack-group.ru/	2
https://rewards.bmoharris.com/	2
https://www.spartan.org/	2
https://www.steelvalleysd.org/	2
https://www.polson.k12.mt.us/	2
https://www.eastmont206.org/	2
https://villazza.jp/	2
http://www.kubiel.pl/	2
https://www.sodiwseries.com/	2
http://36n6.ru/	2
https://www.omaksd.org/	2
https://www.pegrande.com.br/	2
https://offstage.pike13.com/	2
https://www.pizzamario.com/	2
https://fgtas.rs.gov.br/	2
https://atencaobasica.saude.rs.gov.br/	2
https://paidviewpoint.com/	2
https://corpo.metro.ca/	2
https://www.plitka.info/	2
https://cipave.rs.gov.br/	2
https://www.misd.k12.wi.us/	2
https://www.ginza-capital.jp/	2
https://escolar.eb.com/	2
https://www.tonervale.com.br/	2
https://www.brigadamilitar.rs.gov.br/	2
https://www.albionk12.org/	2
https://www.filmfestplatform.com/	2
https://www.agricultura.rs.gov.br/	2
https://rdc-next-basecamp-p1.rdc.moveaws.com/	2
https://seguros.comparamejor.com/	2
https://ghayaonline.com/	2
https://www.ogschool.org/	2
http://catalog.solacc.edu/	2
https://gringo-bar.upmenusite.com/	2
https://www.sd81.org/	2
http://zamow.tuttisanti.pl/	2
https://www.pge.rs.gov.br/	2
https://southlandsfarm.pike13.com/	2
https://app.theo.blue/	2
https://www.centraldocidadao.rs.gov.br/	2
https://www.culto.pl/	2
https://prow.slaskie.pl/	2
https://evaluation.eecertification.com/	2
https://www.monodukuri-kyoto.jp/	2
https://www.kubotax.com/	2
https://www.realbrinquedos.com.br/	2
http://www.preformapet.com.br/	2
https://www.tobuhotel.co.jp/	2
https://www.inovecerto.com.br/	2
https://kimchiken.upmenusite.com/	2
https://www.supersaudavelshopping.com.br/	2
https://www.dermamarengo.com.br/	2
https://www.newmarket.k12.nh.us/	2
https://findsport.ru/	2
https://www.rtsd26.org/	2
https://www.spatower.com/	2
https://www.trygghetsavtal.se/	2
https://eservices.ajmanded.ae/	2
https://www.oftalmomedic.com.pe/	2
https://accusrc.com/	2