chore(ci): add an end job to verify the pipeline finished with success #2991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Feb 20, 2025
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Feb 20, 2025
* main: chore(ci): run compose module tests against the upstream compose projects (testcontainers#2990) chore(ci): add an end job to verify the pipeline finished with success (testcontainers#2991)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 13, 2025
* main: chore: enable empty-block from revive (testcontainers#2994) fix(ci): exclude mkdocs.yml file and sonar.properties from the changed-modules script (testcontainers#2993) chore(ci): run compose module tests against the upstream compose projects (testcontainers#2990) chore(ci): add an end job to verify the pipeline finished with success (testcontainers#2991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds an end job after the tests, if and only if there are modules to be tested. Also updates the GH repo settings to use this end job as GitHub check as the only required check for merging PRs.
The end job needs the
detect-modulesand thetestjobs in order to be run, so it will always run at the end of the pipeline. The job will check if previous jobs failed or were cancelled, failing the job in those cases. Else, it prints out a success message, finishing the job successfully, creating a passed GH check.Why is it important?
After the refactor of the pipeline to run the modified modules, the GH check was not updated (on purpose). This PR allows maintainers to see if a PR satisfies the required GH checks when reviewing and eventually merging a PR.
Related Issues