fix(ci): exclude mkdocs.yml file and sonar.properties from the changed-modules script #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
changed the title
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 13, 2025
* main: chore: enable empty-block from revive (testcontainers#2994) fix(ci): exclude mkdocs.yml file and sonar.properties from the changed-modules script (testcontainers#2993) chore(ci): run compose module tests against the upstream compose projects (testcontainers#2990) chore(ci): add an end job to verify the pipeline finished with success (testcontainers#2991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds an exclusion list of files that won't add all the modules to the changed modules list.
Why is it important?
A PR adding a new module, i.e. scyllaDB, will include changes in the mkdocs.yml file (for the website) and in the sonar.properties file (for sonar).
Before these changes, it would cause all modules to be added to the build, which is not desired.
How to test this PR
Execute the script:
ALL_CHANGED_FILES="modules/kafka/a.go mkdocs.yml" ./scripts/changed-modules.sh The output should be: the modules/kafka module.ALL_CHANGED_FILES="mkdocs.yml sonar-project.properties go.mod" ./scripts/changed-modules.sh The output should be: all modules.ALL_CHANGED_FILES="mkdocs.yml sonar-project.properties" ./scripts/changed-modules.sh The output should be: no modules.