Skip to content

docs: fix reference to container types in Run function #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

mdelapenya
Copy link
Member

What does this PR do?

It updates the Run function code snippets in the recently added modules, as it was incosistent with the real types.

The docs template has been updated to avoid more errors like this one.

Why is it important?

Inconsistent docs cause frustration.

@mdelapenya mdelapenya requested a review from a team as a code owner April 14, 2025 10:14
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Apr 14, 2025
@mdelapenya mdelapenya self-assigned this Apr 14, 2025
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit b923163
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67fce00ed14bc70008acffa5
😎 Deploy Preview https://deploy-preview-3102--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit d4ce674 into testcontainers:main Apr 14, 2025
20 checks passed
@mdelapenya mdelapenya deleted the fix-docs-container branch April 14, 2025 10:24
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Apr 15, 2025
* main:
  chore(deps): bump golang.org/x/crypto in /modules/aerospike (testcontainers#3105)
  chore(ci): run codeql on the modified modules (testcontainers#3103)
  docs: fix reference to container types in Run function (testcontainers#3102)
  chore(deps): bump github.com/golang-jwt/jwt/v5 in /modules/pulsar (testcontainers#3101)
  chore(pulsar): bump github.com/apache/pulsar-client-go from 0.10.0 to 0.14.0 (testcontainers#3100)
  chore(clickhouse): bump github.com/ClickHouse/clickhouse-go/v2 from 2.20.0 to 2.34.0 in /modules/clickhouse (testcontainers#3099)
  chore(deps): bump github/codeql-action from 3.28.13 to 3.28.15 (testcontainers#3097)
  chore(deps): bump golang.org/x/crypto from 0.31.0 to 0.37.0 (testcontainers#3098)
  feat(aerospike): add Aerospike module (testcontainers#3094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant