chore: test cleanup

Author: timdeschryver

.eslintrc.json

@@ -106,7 +106,6 @@
       "files": ["*.spec.ts"],
       "extends": ["plugin:jest/recommended"],
       "rules": {
-        "jest/no-done-callback": "off",
         "jest/expect-expect": "off"
       }
     },

apps/example-app/src/app/examples/14-async-component.spec.ts

@@ -1,4 +1,4 @@
-import { fakeAsync, flush, tick } from '@angular/core/testing';
+import { fakeAsync, tick } from '@angular/core/testing';
 import { render, screen, fireEvent } from '@testing-library/angular';
 
 import { AsyncComponent } from './14-async-component';

apps/example-app/src/app/issues/issue-106.spec.ts

@@ -15,7 +15,7 @@ class TestSelectComponent {
   }
 }
 
-it('https://github.com/testing-library/angular-testing-library/issues/106', async () => {
+test('https://github.com/testing-library/angular-testing-library/issues/106', async () => {
   await render(TestSelectComponent);
   const toggle = screen.getByTestId('toggle');
   const hiddenText = screen.queryByTestId('getme');
@@ -30,7 +30,7 @@ it('https://github.com/testing-library/angular-testing-library/issues/106', asyn
   await waitFor(() => expect(screen.queryByTestId('getme')).toBeInTheDocument());
 });
 
-it('better https://github.com/testing-library/angular-testing-library/issues/106', async () => {
+test('better https://github.com/testing-library/angular-testing-library/issues/106', async () => {
   await render(TestSelectComponent);
   const toggle = screen.getByTestId('toggle');
   const hiddenText = screen.queryByTestId('getme');

jest.preset.js

@@ -7,12 +7,6 @@ module.exports = {
   },
   resolver: '@nrwl/jest/plugins/resolver',
   moduleFileExtensions: ['ts', 'js', 'html'],
-  coverageReporters: ['html'],
-  snapshotSerializers: [
-    'jest-preset-angular/build/serializers/no-ng-attributes',
-    'jest-preset-angular/build/serializers/ng-snapshot',
-    'jest-preset-angular/build/serializers/html-comment',
-  ],
   globals: {
     'ts-jest': {
       tsconfig: '<rootDir>/tsconfig.spec.json',

projects/jest-utils/tests/create-mock.spec.ts

@@ -24,12 +24,12 @@ class FixtureComponent {
   }
 }
 
-it('mocks all functions', () => {
+test('mocks all functions', () => {
   const mock = createMock(FixtureService);
   expect(mock.print.mock).toBeDefined();
 });
 
-it('provides a mock service', async () => {
+test('provides a mock service', async () => {
   const { getByText } = await render(FixtureComponent, {
     providers: [provideMock(FixtureService)],
   });
@@ -39,7 +39,7 @@ it('provides a mock service', async () => {
   expect(service.print).toHaveBeenCalledTimes(1);
 });
 
-it('is possible to write a mock implementation', async () => {
+test('is possible to write a mock implementation', async () => {
   const { getByText } = await render(FixtureComponent, {
     providers: [provideMock(FixtureService)],
   });

projects/testing-library/tests/issues/issue-188.spec.ts

@@ -17,7 +17,7 @@ class BugOnChangeComponent implements OnChanges {
   }
 }
 
-it('should output formatted name after rendering', async () => {
+test('should output formatted name after rendering', async () => {
   const { getByText } = await render(BugOnChangeComponent, { componentProperties: { name: 'name' } });
 
   getByText('Hello NAME');

projects/testing-library/tests/issues/issue-67.spec.ts

@@ -15,11 +15,11 @@ import { render } from '../../src/public_api';
 })
 class BugGetByLabelTextComponent {}
 
-it('first step to reproduce the bug: skip this test to avoid the error or remove the for attribute of label', async () => {
+test('first step to reproduce the bug: skip this test to avoid the error or remove the for attribute of label', async () => {
   expect(await render(BugGetByLabelTextComponent)).toBeDefined();
 });
 
-it('second step: bug happens :`(', async () => {
+test('second step: bug happens :`(', async () => {
   const { getByLabelText, getByTestId } = await render(BugGetByLabelTextComponent);
 
   const checkboxByTestId = getByTestId('checkbox');

projects/testing-library/tests/render.spec.ts

@@ -126,28 +126,19 @@ describe('Angular component life-cycle hooks', () => {
   });
 });
 
-test('Waits for angular app initialization before rendering components', (done) => {
-  let resolve;
+test('waits for angular app initialization before rendering components', async () => {
+  const mock = jest.fn();
 
-  const promise = new Promise((res) => {
-    resolve = res;
-  });
-
-  render(FixtureComponent, {
+  await render(FixtureComponent, {
     providers: [
       {
         provide: APP_INITIALIZER,
-        useFactory: () => () => promise,
+        useFactory: () => mock,
         multi: true,
       },
     ],
-  })
-    .then(() => {
-      expect(TestBed.inject(ApplicationInitStatus).done).toEqual(true);
-      done();
-    })
-    .catch(done);
-
-  // Wait a bit so the test will fail if render completes without us resolving the promise
-  setTimeout(resolve, 1000);
+  });
+
+  expect(TestBed.inject(ApplicationInitStatus).done).toEqual(true);
+  expect(mock).toHaveBeenCalled();
 });