Skip to content

Collapse consecutive blank lines if there's no title #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

Collapse consecutive blank lines if there's no title #145

merged 1 commit into from
Oct 22, 2020

Conversation

chocolateboy
Copy link
Contributor

@chocolateboy chocolateboy commented Mar 23, 2018 •
edited
Loading

Closes #101

before

# example

<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->


- [NAME](#name)
- [SYNOPSIS](#synopsis)
- [DESCRIPTION](#description)
- [EXPORTS](#exports)
  - [foo](#foo)
  - [bar](#bar)
  - [baz](#baz)
- [SEE ALSO](#see-also)
- [AUTHOR](#author)
- [COPYRIGHT AND LICENSE](#copyright-and-license)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

after

# example

<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

- [NAME](#name)
- [SYNOPSIS](#synopsis)
- [DESCRIPTION](#description)
- [EXPORTS](#exports)
  - [foo](#foo)
  - [bar](#bar)
  - [baz](#baz)
- [SEE ALSO](#see-also)
- [AUTHOR](#author)
- [COPYRIGHT AND LICENSE](#copyright-and-license)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

karfau
karfau approved these changes Mar 25, 2018
View reviewed changes
Copy link

@karfau karfau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, clear and reasonable.
Thx for the contribution.
Let's hope this can be merged soon.

@chocolateboy chocolateboy changed the title collapse consecutive blank lines if there's no title (closes #101) Collapse consecutive blank lines if there's no title Jun 19, 2020
@kdeldycke
Copy link

Most Markdown linters recognize double empty lines in this context as violations. See for instance: https://github.com/kdeldycke/awesome-iam/pull/9/files#diff-0730bb7c2e8f9ea2438b52e419dd86c9

This PR is a great contribution as it allows the production of clean Markdown right away.

@kdeldycke
Copy link

Thanks @chocolateboy for this attention to details! :)

kdeldycke added a commit to kdeldycke/awesome-iam that referenced this pull request Jul 10, 2020
@kdeldycke
Generates title as part of the TOC to avoid extra non-conform blank l…
8b09439 
…ines.

See:
* thlorenz/doctoc#101
* thlorenz/doctoc#145
AndrewSouthpaw
AndrewSouthpaw approved these changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@AndrewSouthpaw AndrewSouthpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@AndrewSouthpaw AndrewSouthpaw merged commit bf7896b into thlorenz:master Oct 22, 2020
kdeldycke added a commit to kdeldycke/awesome-falsehood that referenced this pull request Dec 7, 2020
@kdeldycke
No need to force TOC section title in CLI with doctoc 2.0.0.
fab8fbd 
See: thlorenz/doctoc#145
kdeldycke added a commit to kdeldycke/awesome-engineering-team-management that referenced this pull request Dec 7, 2020
@kdeldycke
No need to force TOC section title in CLI with doctoc 2.0.0.
008542e 
See: thlorenz/doctoc#145
kdeldycke added a commit to kdeldycke/awesome-iam that referenced this pull request Dec 7, 2020
@kdeldycke
No need to force TOC section title in CLI with doctoc 2.0.0.
82b68eb 
See: thlorenz/doctoc#145
kdeldycke added a commit to kdeldycke/awesome-billing that referenced this pull request Dec 7, 2020
@kdeldycke
No need to force TOC section title in CLI with doctoc 2.0.0.
050a205 
See: thlorenz/doctoc#145
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
mohammadabdullahrihan added a commit to mohammadabdullahrihan/-Billing-Payments-knowledge that referenced this pull request Mar 20, 2025
@mohammadabdullahrihan
No need to force TOC section title in CLI with doctoc 2.0.0.
fbe7dc2 
See: thlorenz/doctoc#145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karfau karfau karfau approved these changes

@AndrewSouthpaw AndrewSouthpaw AndrewSouthpaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doctoc --notitle creates a superfluous blank line
4 participants
@chocolateboy @kdeldycke @karfau @AndrewSouthpaw