Transparently keep reference of routers in urls generated by routers #4443
+47
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly change the behavior of routers, to ensure that when they create a url pattern (
RegexURLPattern
orRegexURLResolver
), it keeps a reference of the router.The reason for this is to enhance reflexion possibilities on DRF for third-party libraries (I actually decided to suggest this because working with
django-rest-framework-docs
, I figured out that the support of Viewsets was complicated because the library focuses on api endpoints, and then cannot automatically discover routers - and thus methods mapping).Important: The changes made in this PR is completely transparent for DRF users.
What I actually did: I created a subclass of django's
RegexURLPattern
(DrfRegexURLPattern
) and a subclass of django'sRegexURLResolver
(DrfRegexURLResolver
), both adding a router property to their super class, but behaving exactly the same. I also rewrited thedjango.conf.urls.url
function to make it instantiateDrfRegexURLPattern
andDrfRegexURLResolver
, and replaced django's one by this one in theget_urls
method of routers.