Skip to content

Add email provider #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2016
Merged

Add email provider #27

merged 1 commit into from
Nov 23, 2016

Conversation

calvera
Copy link
Contributor

@calvera calvera commented Nov 23, 2016

allow using email instead of username

@cryptiklemur
Copy link
Contributor

I'm a little confused. This doesn't seem to do anything.

@calvera
Copy link
Contributor Author

calvera commented Nov 23, 2016

see this https://symfony.com/doc/current/bundles/FOSUserBundle/logging_by_username_or_email.html

@cryptiklemur
Copy link
Contributor

Yes, but this provider ONLY fetches by ID. You just copied the user provider, and changed the name of the class. Nothing is done with an email here.

@calvera
Copy link
Contributor Author

calvera commented Nov 23, 2016

really? :)

https://github.com/calvera/api-key-bundle/blob/email-provider/src/Uecode/Bundle/ApiKeyBundle/Security/Authentication/Provider/EmailUserProvider.php#L4

@cryptiklemur
Copy link
Contributor

Ill merge it, but im not really sure how this is being used. Its fetching by API key, not by username/email.

@cryptiklemur cryptiklemur merged commit deb2abd into uecode:master Nov 23, 2016
@calvera calvera mentioned this pull request Nov 24, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvera @cryptiklemur