From 53263c230e806866d9e9216def3bb010f54a8f8b Mon Sep 17 00:00:00 2001 From: Ruslan Gunawardana Date: Sun, 7 Jan 2018 01:03:58 +0200 Subject: [PATCH 1/4] Comment typo fixed in /build TypeScript comment typo in file /build/build.js --- template/build/build.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/build/build.js b/template/build/build.js index 2b648b810c..11eb43759c 100644 --- a/template/build/build.js +++ b/template/build/build.js @@ -22,7 +22,7 @@ rm(path.join(config.build.assetsRoot, config.build.assetsSubDirectory), err => { process.stdout.write(stats.toString({ colors: true, modules: false, - children: false, // if you are using ts-loader, setting this to true will make tyescript errors show up during build + children: false, // if you are using ts-loader, setting this to true will make typescript errors show up during build chunks: false, chunkModules: false }) + '\n\n') From 24313482109dfd623be6cf2bcb6f3f0da5746302 Mon Sep 17 00:00:00 2001 From: Ruslan Gunawardana Date: Sun, 7 Jan 2018 02:55:24 +0200 Subject: [PATCH 2/4] Whitespace refactoring in Unit tests --- template/test/unit/specs/HelloWorld.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/test/unit/specs/HelloWorld.spec.js b/template/test/unit/specs/HelloWorld.spec.js index 8951ac95b5..1c75ca64cd 100644 --- a/template/test/unit/specs/HelloWorld.spec.js +++ b/template/test/unit/specs/HelloWorld.spec.js @@ -6,6 +6,6 @@ describe('HelloWorld.vue', () => { const Constructor = Vue.extend(HelloWorld) const vm = new Constructor().$mount() expect(vm.$el.querySelector('.hello h1').textContent) - {{#if_eq runner "karma"}}.to.equal('Welcome to Your Vue.js App'){{/if_eq}}{{#if_eq runner "jest"}}.toEqual('Welcome to Your Vue.js App'){{/if_eq}} + {{#if_eq runner "karma"}}.to.equal('Welcome to Your Vue.js App'){{/if_eq}}{{#if_eq runner "jest"}}.toEqual('Welcome to Your Vue.js App'){{/if_eq}} }) }) From 7918e4ae8f6992ac0735781ea7be8be7bc2a26f9 Mon Sep 17 00:00:00 2001 From: Ruslan Gunawardana Date: Sun, 7 Jan 2018 03:20:03 +0200 Subject: [PATCH 3/4] App component name PascalCase ESLint 'plugin:vue/recommended' detects this code style error. It violates the Style Guide rule: https://vuejs.org/v2/style-guide/#Component-name-casing-in-templates-strongly-recommended --- template/src/App.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/src/App.vue b/template/src/App.vue index 03d5e7247d..0156030e49 100644 --- a/template/src/App.vue +++ b/template/src/App.vue @@ -15,7 +15,7 @@ import HelloWorld from './components/HelloWorld' {{/unless}} export default { - name: 'app'{{#router}}{{else}}, + name: 'App'{{#router}}{{else}}, components: { HelloWorld }{{/router}} From 182bb0ab16f96f2061be6dd9c26485f5ef5f3a2e Mon Sep 17 00:00:00 2001 From: Ruslan Gunawardana Date: Sun, 7 Jan 2018 05:27:11 +0200 Subject: [PATCH 4/4] Style Guide refactoring: HelloWorld.vue ESLint 'plugin:vue/recommended' detects the code style error in src/components/HelloWorld.js. It violates the Style Guide Strongly Recommended Rule: https://vuejs.org/v2/style-guide/#Multi-attribute-elements-strongly-recommended --- template/src/components/HelloWorld.vue | 81 +++++++++++++++++++++++--- 1 file changed, 72 insertions(+), 9 deletions(-) diff --git a/template/src/components/HelloWorld.vue b/template/src/components/HelloWorld.vue index 6f18621654..ce0edd8ac1 100644 --- a/template/src/components/HelloWorld.vue +++ b/template/src/components/HelloWorld.vue @@ -3,19 +3,82 @@

\{{ msg }}

Essential Links

Ecosystem