From 1aed1cc3425713f029d13d0fae84d730a2aefb5d Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Wed, 11 Sep 2019 15:43:52 +0800 Subject: [PATCH 1/2] refactor!: make workbox-webpack-plugin a peer dependency Considering workbox team is preparing a v5 release. It's likely that in the early-to-middle stage of Vue CLI v4 lifecycle that a major version bump of workbox may happen. By making it a peer dep we could have more flexibility on version strategies. --- packages/@vue/cli-plugin-pwa/generator/index.js | 3 +++ packages/@vue/cli-plugin-pwa/package.json | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/@vue/cli-plugin-pwa/generator/index.js b/packages/@vue/cli-plugin-pwa/generator/index.js index fe1f48c2f0..def98eb177 100644 --- a/packages/@vue/cli-plugin-pwa/generator/index.js +++ b/packages/@vue/cli-plugin-pwa/generator/index.js @@ -2,6 +2,9 @@ module.exports = api => { api.extendPackage({ dependencies: { 'register-service-worker': '^1.6.2' + }, + devDependencies: { + 'workbox-webpack-plugin': '^4.3.1' } }) api.injectImports(api.entryFile, `import './registerServiceWorker'`) diff --git a/packages/@vue/cli-plugin-pwa/package.json b/packages/@vue/cli-plugin-pwa/package.json index 4b0330dec9..deb79fe843 100644 --- a/packages/@vue/cli-plugin-pwa/package.json +++ b/packages/@vue/cli-plugin-pwa/package.json @@ -24,13 +24,13 @@ }, "dependencies": { "@vue/cli-shared-utils": "^4.0.0-rc.3", - "webpack": "^4.0.0", - "workbox-webpack-plugin": "^4.3.1" + "webpack": "^4.0.0" }, "devDependencies": { "register-service-worker": "^1.6.2" }, "peerDependencies": { - "@vue/cli-service": "^3.0.0 || ^4.0.0-0" + "@vue/cli-service": "^3.0.0 || ^4.0.0-0", + "workbox-webpack-plugin": "^4.3.1" } } From 65f8de9f99a73c7b7ae9cfb468b776cd152aa70f Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Wed, 11 Sep 2019 15:58:24 +0800 Subject: [PATCH 2/2] fix: fix dependency not found error --- packages/@vue/cli-plugin-pwa/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/@vue/cli-plugin-pwa/package.json b/packages/@vue/cli-plugin-pwa/package.json index deb79fe843..34072e0491 100644 --- a/packages/@vue/cli-plugin-pwa/package.json +++ b/packages/@vue/cli-plugin-pwa/package.json @@ -27,7 +27,8 @@ "webpack": "^4.0.0" }, "devDependencies": { - "register-service-worker": "^1.6.2" + "register-service-worker": "^1.6.2", + "workbox-webpack-plugin": "^4.3.1" }, "peerDependencies": { "@vue/cli-service": "^3.0.0 || ^4.0.0-0",