misc(serve): change async await and use includes for args

Author: knagaitsev

lib/bootstrap.js

@@ -12,7 +12,7 @@ const normalizeFlags = (args, cmd) => {
         return slicedArgs.filter(arg => !isArgCommandName(arg, cmd));
     }
     else {
-        return slicedArgs.filter(arg => arg.indexOf('--') < 0 && !isArgCommandName(arg, cmd));
+        return slicedArgs.filter(arg => !arg.includes('--') && !isArgCommandName(arg, cmd));
     }
 };
 
@@ -52,9 +52,6 @@ async function runCLI(cli, commandIsUsed) {
     }
 }
 
-// eslint-disable-next-line space-before-function-paren
-(async () => {
-    const commandIsUsed = isCommandUsed(commands);
-    const cli = new WebpackCLI();
-    await runCLI(cli, commandIsUsed);
-})();
+const commandIsUsed = isCommandUsed(commands);
+const cli = new WebpackCLI();
+runCLI(cli, commandIsUsed);

lib/utils/compiler.js

@@ -112,8 +112,8 @@ function compilerCallback(compiler, err, stats, lastHash, options, outputOptions
     }
 }
 
-async function getCompiler(opts) {
-    return await webpack(opts.options);
+function getCompiler(opts) {
+    return webpack(opts.options);
 }
 
 async function webpackInstance(opts, shouldUseMem) {
@@ -203,7 +203,5 @@ async function webpackInstance(opts, shouldUseMem) {
     }
 };
 
-module.exports = {
-    getCompiler,
-    webpackInstance,
-};
+module.exports.getCompiler = getCompiler;
+module.exports.webpackInstance = webpackInstance;

packages/serve/flags.js

@@ -74,35 +74,6 @@ module.exports = {
             type: String,
             describe: 'Open default browser with the specified page',
         },
-        // instead of this option, we should consider retrieving the 'color' option
-        // from the compiler (since webpack CLI already has 'color' option)
-        // also, we should reconsider how to use supports-color with command-line-args
-        // {
-        //     name: 'colors',
-        //     type: Boolean,
-        //     // alias: 'color',
-        //     defaultValue: function supportsColor() {
-        //         // Use `require('supports-color').stdout` for supports-color >= 5.0.0.
-        //         // See https://github.com/webpack/webpack-dev-server/pull/1555.
-        //         return require('supports-color').stdout;
-        //     },
-        //     group: DISPLAY_GROUP,
-        //     describe: 'Enables/Disables colors on the console',
-        // },
-        // we need to rethink this option, since it is CLI only at the moment
-        // {
-        //     name: 'info',
-        //     type: Boolean,
-        //     group: DISPLAY_GROUP,
-        //     defaultValue: true,
-        //     describe: 'Info',
-        // },
-        {
-            name: 'quiet',
-            type: Boolean,
-            group: DISPLAY_GROUP,
-            describe: 'Quiet',
-        },
         {
             name: 'client-log-level',
             type: String,