Skip to content

Commit 68a1f29

Browse files
authored
chore(deps): update webpack to 4.39.0 (#2171)
1 parent c2da532 commit 68a1f29

File tree

4 files changed

+73
-45
lines changed

4 files changed

+73
-45
lines changed

package-lock.json

Lines changed: 63 additions & 39 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
"tcp-port-used": "^1.0.1",
111111
"typescript": "^3.5.3",
112112
"url-loader": "^1.1.2",
113-
"webpack": "^4.38.0",
113+
"webpack": "^4.39.0",
114114
"webpack-cli": "^3.3.6"
115115
},
116116
"peerDependencies": {

test/cli/cli.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ describe('CLI', () => {
3434
.then((output) => {
3535
expect(output.code).toEqual(0);
3636
// should profile
37-
expect(
38-
output.stderr.includes('ms after chunk modules optimization')
39-
).toBe(true);
37+
expect(output.stderr.includes('after chunk modules optimization')).toBe(
38+
true
39+
);
4040
done();
4141
})
4242
.catch(done);

test/server/profile-option.test.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,21 @@ describe('profile', () => {
3030
mockStderr.mockRestore();
3131
let foundProgress = false;
3232
let foundProfile = false;
33+
3334
calls.forEach((call) => {
34-
if (call[0].includes('0% compiling')) {
35+
const text = call[0];
36+
37+
if (text.includes('0% compiling')) {
3538
foundProgress = true;
3639
}
3740

3841
// this is an indicator that the profile option is enabled,
3942
// so we should expect to find it in stderr since profile is enabled
40-
if (call[0].includes('ms after chunk modules optimization')) {
43+
if (text.includes('after chunk modules optimization')) {
4144
foundProfile = true;
4245
}
4346
});
47+
4448
expect(foundProgress).toBeTruthy();
4549
expect(foundProfile).toBeTruthy();
4650

0 commit comments

Comments
 (0)