Skip to content

chore(deps): update dependency chokidar to v3 - autoclosed #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 30, 2019

This PR contains the following updates:

Package Type Update Change References
chokidar dependencies major ^2.1.5 -> ^3.0.0 source

Release Notes

paulmillr/chokidar

v3.0.0

Compare Source

Massive CPU & RAM consumption improvements. 17x package & deps size reduction. Node 8+-only


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@hiroppy
Copy link
Member

hiroppy commented Apr 30, 2019

State similar to #1834 (comment)

   C:\projects\webpack-dev-server\node_modules\readdirp\index.js:94
        const opts = { ...ReaddirpStream.defaultOptions,
                       ^^^
    SyntaxError: Unexpected token ...
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:471:17)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:513:25)
      at Object.<anonymous> (node_modules/chokidar/index.js:9:18)

@renovate renovate bot force-pushed the renovate/chokidar-3.x branch 8 times, most recently from 11f19aa to 40f2f26 Compare May 8, 2019 17:20
@renovate renovate bot force-pushed the renovate/chokidar-3.x branch 4 times, most recently from 6ffc168 to e3ff463 Compare May 10, 2019 18:36
@renovate renovate bot force-pushed the renovate/chokidar-3.x branch 2 times, most recently from 1e23a70 to d5f6893 Compare May 13, 2019 10:28
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #1835 into master will increase coverage by 5.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
+ Coverage   87.85%   93.67%   +5.82%     
==========================================
  Files          14        4      -10     
  Lines         782      174     -608     
  Branches      256       88     -168     
==========================================
- Hits          687      163     -524     
+ Misses         82       10      -72     
+ Partials       13        1      -12
Impacted Files Coverage Δ
lib/utils/createDomain.js 71.42% <0%> (-28.58%) ⬇️
lib/Server.js
lib/utils/runBonjour.js
lib/utils/getCertificate.js
lib/utils/findPort.js
lib/utils/colors.js
lib/utils/updateCompiler.js
lib/utils/createLogger.js
lib/utils/status.js
lib/utils/createCertificate.js
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4b44d...a5afaf5. Read the comment docs.

@alexander-akait
Copy link
Member

/cc @hiroppy To be honestly i think we should migrate on built-in webpack watch system, without directly using chokidar, need investigate how we can do it, maybe export some api

@renovate renovate bot force-pushed the renovate/chokidar-3.x branch 2 times, most recently from 9012341 to b78472a Compare May 13, 2019 15:28
@hiroppy
Copy link
Member

hiroppy commented May 13, 2019

OK, Let's include it in our future plans:)

@alexander-akait
Copy link
Member

Added to roadmap

@renovate renovate bot force-pushed the renovate/chokidar-3.x branch 3 times, most recently from 5ee158a to 7da6d06 Compare May 14, 2019 18:40
@renovate renovate bot force-pushed the renovate/chokidar-3.x branch from 7da6d06 to a5afaf5 Compare May 15, 2019 07:49
@renovate renovate bot changed the title chore(deps): update dependency chokidar to v3 chore(deps): update dependency chokidar to v3 - autoclosed May 15, 2019
@renovate renovate bot closed this May 15, 2019
@renovate renovate bot deleted the renovate/chokidar-3.x branch May 15, 2019 12:38
@fabiomcosta
Copy link

Sounds like chokidar v2 depends on fsevents@v1 on macos, which doesn't work with node12.
Can't chokidar be update for now while waiting for this other suggested refactor?

@alexander-akait
Copy link
Member

No problems with watch on CI with node@12 and node@13, try to update lock file

@fabiomcosta
Copy link

fabiomcosta commented Jan 29, 2020

Sorry about the misinformation, and thank you very much for answering.
[email protected] works with node v12, so I just had to make sure it got updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants